Skip to content

feat: add stats/strided/dnancumax#10562

Open
Om-A-osc wants to merge 4 commits intostdlib-js:developfrom
Om-A-osc:feat/stats-strided-dnancumax
Open

feat: add stats/strided/dnancumax#10562
Om-A-osc wants to merge 4 commits intostdlib-js:developfrom
Om-A-osc:feat/stats-strided-dnancumax

Conversation

@Om-A-osc
Copy link
Contributor

@Om-A-osc Om-A-osc commented Feb 28, 2026

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: passed
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: passed
  • task: lint_c_examples status: passed
  • task: lint_c_benchmarks status: passed
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed

Resolves none.

Description

This pull request adds the @stdlib/stats/strided/dnancumax package, which computes the cumulative maximum of double-precision strided arrays while ignoring NaN values.

Related Issues

None.

Questions

No.

Other

No.

Checklist

AI Assistance

  • No

@stdlib-js/reviewers

@Om-A-osc
feat: add stats/strided/dnancumax
f420a27 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 28, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 28, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/strided/dnancumax $\color{green}405/405$
$\color{green}+100.00%$ 		$\color{green}26/26$
$\color{green}+100.00%$ 		$\color{green}4/4$
$\color{green}+100.00%$ 		$\color{green}405/405$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@Om-A-osc
Copy link
Contributor Author

Om-A-osc commented Feb 28, 2026

@Sachinn-64 Hey If you have some time I would love to have your review on this.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 2, 2026
@Om-A-osc
fix: sync js examples in README
7c954e7 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Om-A-osc
Copy link
Contributor Author

Om-A-osc commented Mar 2, 2026

@Planeshifter Done!

@Planeshifter
style: add trailing empty line
a7f7271 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter previously approved these changes Mar 2, 2026
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 2, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 2, 2026

PR Commit Message

feat: add `stats/strided/dnancumax`

PR-URL: https://github.com/stdlib-js/stdlib/pull/10562

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 2, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 2, 2026

/stdlib-merge

@Om-A-osc, slash command not recognized. Please use /stdlib help to view available commands.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 2, 2026
@Om-A-osc
Copy link
Contributor Author

Om-A-osc commented Mar 2, 2026

/stdlib help

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 2, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 2, 2026

@Om-A-osc, available slash commands include:

  • /stdlib check-files - Check for required files.
  • /stdlib make-commands - Print make commands for package changed in PR.
  • /stdlib update-copyright-years - Update copyright header years.
  • /stdlib lint-autofix - Auto-fix lint errors.
  • /stdlib merge - Merge changes from develop branch into this PR.
  • /stdlib rebase - Rebase this PR on top of develop branch.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 2, 2026
kgryte
kgryte reviewed Mar 3, 2026
View reviewed changes
kgryte
kgryte requested changes Mar 3, 2026
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left initial comments.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. difficulty: 3 Likely to be challenging but manageable. review: 3 and removed Ready To Merge A pull request which is ready to be merged. labels Mar 3, 2026
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Mar 3, 2026
@Om-A-osc
fix: addressing second round comments
2fbaaf5 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Om-A-osc
Copy link
Contributor Author

Om-A-osc commented Mar 3, 2026

@kgryte Done!

@Om-A-osc Om-A-osc requested a review from kgryte March 3, 2026 16:41
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter left review comments

@kgryte kgryte Awaiting requested review from kgryte

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

difficulty: 3 Likely to be challenging but manageable. Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. review: 3 Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Om-A-osc @stdlib-bot @Planeshifter @kgryte